Skip to content

GraphQL Ruby 2.5 compatibility #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gmac merged 1 commit into from
Apr 22, 2025
Merged

GraphQL Ruby 2.5 compatibility #170

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@ jobs:
include:
- gemfile: Gemfile
ruby: 3.3
- gemfile: gemfiles/graphql_2.4.0.gemfile
ruby: 3.2
- gemfile: gemfiles/graphql_2.3.0.gemfile
ruby: 3.2
- gemfile: gemfiles/graphql_2.2.0.gemfile
Expand Down
9 changes: 9 additions & 0 deletions gemfiles/graphql_2.4.0.gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
# frozen_string_literal: true

source 'https://rubygems.org'

gem 'graphql', '~> 2.4.0'
gem 'warning'
gem 'minitest-stub-const'

gemspec path: "../"
4 changes: 2 additions & 2 deletions lib/graphql/stitching/composer.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,11 @@ module Stitching
class Composer
# @api private
NO_DEFAULT_VALUE = begin
class T < GraphQL::Schema::Object
t = Class.new(GraphQL::Schema::Object) do
field(:f, String) { _1.argument(:a, String) }
end

T.get_field("f").get_argument("a").default_value
t.get_field("f").get_argument("a").default_value
end

# @api private
Expand Down
2 changes: 0 additions & 2 deletions lib/graphql/stitching/supergraph.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,6 @@ class Supergraph

def initialize(schema:, fields: {}, resolvers: {}, executables: {})
@schema = schema
@schema.use(GraphQL::Schema::AlwaysVisible)

@resolvers = resolvers
@resolvers_by_version = nil
@fields_by_type_and_location = nil
Expand Down
2 changes: 1 addition & 1 deletion lib/graphql/stitching/version.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,6 @@

module GraphQL
module Stitching
VERSION = "1.6.0"
VERSION = "1.6.1"
end
end
Loading