configure: quote the HAVE_IO_URING description as m4, not a C string - #4767
Open
ThalesBarretto wants to merge 1 commit into
Open
configure: quote the HAVE_IO_URING description as m4, not a C string#4767ThalesBarretto wants to merge 1 commit into
ThalesBarretto wants to merge 1 commit into
Conversation
ThalesBarretto
marked this pull request as draft
September 10, 2026 17:29
ThalesBarretto
marked this pull request as ready for review
September 11, 2026 02:09
AC_DEFINE([HAVE_IO_URING], [1], "io_uring support") passed the description as a double-quoted C string rather than an m4-quoted [io_uring support]. The literal quotes end up in the config.h comment. It is the only AC_DEFINE in configure.ac written this way. Use the standard m4 bracket quoting to match every other definition. Fixes: gluster#4766 Signed-off-by: Thales Antunes de Oliveira Barretto <thales.barretto.git@gmail.com>
ThalesBarretto
force-pushed
the
build-io-uring-define-description
branch
from
September 11, 2026 02:10
eb860ef to
e929d3e
Compare
amarts
approved these changes
Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AC_DEFINE([HAVE_IO_URING], [1], "io_uring support")passed thedescription as a double-quoted C string rather than an m4-quoted
[io_uring support]. The literal quotes end up in theconfig.hcomment (
/* "io_uring support" */instead of/* io_uring support */).It is the only
AC_DEFINEinconfigure.acwritten this way; the otherfive 3-argument definitions all use the correct
[...]quoting. The#define HAVE_IO_URING 1itself is unaffected — the defect is cosmeticand a quoting anti-pattern, not a build break.
Fixes: #4766