Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert structure of per_thread_pool_list_t #3952

Merged
merged 1 commit into from
Jan 16, 2023
Merged

Revert structure of per_thread_pool_list_t #3952

merged 1 commit into from
Jan 16, 2023

Conversation

black-dragon74
Copy link
Member

@black-dragon74 black-dragon74 commented Jan 10, 2023

Signed-off-by: black.dragon74 nickk.2974@gmail.com

Fixes: #3941

Signed-off-by: black.dragon74 <nickk.2974@gmail.com>
@mykaul
Copy link
Contributor

mykaul commented Jan 10, 2023

It's missing a reference to an issue - I assume it fixes #3941 ?

@mohit84
Copy link
Contributor

mohit84 commented Jan 10, 2023

It's missing a reference to an issue - I assume it fixes #3941 ?

Yes, correct, Thanks for updating it.

@mohit84
Copy link
Contributor

mohit84 commented Jan 10, 2023

/run regression

@feizai131
Copy link

feizai131 commented Jan 13, 2023

pool_list_size = sizeof(per_thread_pool_list_t) +
sizeof(per_thread_pool_t) * NPOOLS-1 , NPOOLS-1 modifies NPOOLS for easier understanding

@mohit84
Copy link
Contributor

mohit84 commented Jan 13, 2023

pool_list_size = sizeof(per_thread_pool_list_t) + sizeof(per_thread_pool_t) * NPOOLS-1 , NPOOLS-1 modifies NPOOLS for easier understanding

After declaring a single element array in per_thread_pool_list_t we don't need to declare memory for NPOOLS, NPOOLS-1 + 1(declared as a per_thread_pool_list) will care for the full array.

@mohit84 mohit84 merged commit c7cf19f into gluster:devel Jan 16, 2023
amarts pushed a commit to kadalu/glusterfs that referenced this pull request Mar 20, 2023
Fixes: gluster#3941
Signed-off-by: black.dragon74 <nickk.2974@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mempool Memory out of bounds
4 participants