Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

posix: fix compilation issue #3505

Merged
merged 1 commit into from
May 7, 2022
Merged

Conversation

xhernandez
Copy link
Contributor

An issue has been introduced as a result of commits fa5861b and
203703e. This patch fixes the issue by making function
posix_handle_unset_gfid() non static.

Change-Id: I97a5d1d36a908deec94b09b7e548f9d1def2880c
Signed-off-by: Xavi Hernandez xhernandez@redhat.com

An issue has been introduced as a result of commits fa5861b and
203703e. This patch fixes the issue by making function
`posix_handle_unset_gfid()` non static.

Change-Id: I97a5d1d36a908deec94b09b7e548f9d1def2880c
Signed-off-by: Xavi Hernandez <xhernandez@redhat.com>
@xhernandez
Copy link
Contributor Author

/run regression

@gluster-ant
Copy link
Collaborator

1 test(s) failed
./tests/bugs/read-only/bug-1134822-read-only-default-in-graph.t

0 test(s) generated core

4 test(s) needed retry
./tests/000-flaky/basic_mount-nfs-auth.t
./tests/000-flaky/bugs_nfs_bug-1116503.t
./tests/000-flaky/glusterd-restart-shd-mux.t
./tests/bugs/read-only/bug-1134822-read-only-default-in-graph.t

2 flaky test(s) marked as success even though they failed
./tests/000-flaky/basic_mount-nfs-auth.t
./tests/000-flaky/bugs_nfs_bug-1116503.t
https://build.gluster.org/job/gh_centos7-regression/2474/

@xhernandez
Copy link
Contributor Author

/run regression

@xhernandez xhernandez requested review from pranithk, amarts and mohit84 May 7, 2022 06:01
@mohit84 mohit84 merged commit 0990cb8 into gluster:devel May 7, 2022
@xhernandez xhernandez deleted the compile-issue branch May 9, 2022 08:33
@mykaul
Copy link
Contributor

mykaul commented May 10, 2022

Thanks - how did fa5861b pass CI?

@xhernandez
Copy link
Contributor Author

Thanks - how did fa5861b pass CI?

Regression was run before the other patch got merged, so it passed. Only way to prevent that is to run at least a compile test before merging, but I don't know if this can be done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants