glusterd: refactor to use simpler dict APIs (#3620)

Refactor to prefer 'dict_set_XXX_sizen()' and 'dict_get_YYY()'
dict API functions to avoid a lot of explicit 'SLEN()' calls,
adjust style and comments. No (expected) functional changes.

Signed-off-by: Dmitry Antipov <dantipov@cloudlinux.com>
Suggested-by: Yaniv Kaul <ykaul@redhat.com>
Updates: #1000

xlators/mgmt/glusterd/src/glusterd-conn-mgmt.c

@@ -42,8 +42,7 @@ glusterd_conn_init(glusterd_conn_t *conn, char *sockpath, time_t frame_timeout,
     if (ret)
         goto out;
 
-    ret = dict_set_int32n(options, "transport.socket.ignore-enoent",
-                          SLEN("transport.socket.ignore-enoent"), 1);
+    ret = dict_set_int32_sizen(options, "transport.socket.ignore-enoent", 1);
     if (ret) {
         gf_smsg(this->name, GF_LOG_ERROR, -ret, GD_MSG_DICT_SET_FAILED,
                 "Key=transport.socket.ignore-enoent", NULL);

xlators/mgmt/glusterd/src/glusterd-gfproxyd-svc.c

@@ -115,9 +115,8 @@ glusterd_gfproxydsvc_init(glusterd_volinfo_t *volinfo)
         goto out;
     }
 
-    if (dict_get_strn(this->options, "transport.socket.bind-address",
-                      SLEN("transport.socket.bind-address"),
-                      &volfileserver) != 0) {
+    if (dict_get_str(this->options, "transport.socket.bind-address",
+                     &volfileserver) != 0) {
         volfileserver = "localhost";
     }
     ret = glusterd_proc_init(&(svc->proc), gfproxyd_svc_name, pidfile, logdir,
@@ -320,9 +319,8 @@ glusterd_gfproxydsvc_start(glusterd_svc_t *svc, int flags)
 
     if (volinfo->memory_accounting)
         runner_add_arg(&runner, "--mem-accounting");
-    if (dict_get_strn(priv->opts, GLUSTERD_LOCALTIME_LOGGING_KEY,
-                      SLEN(GLUSTERD_LOCALTIME_LOGGING_KEY),
-                      &localtime_logging) == 0) {
+    if (dict_get_str(priv->opts, GLUSTERD_LOCALTIME_LOGGING_KEY,
+                     &localtime_logging) == 0) {
         if (strcmp(localtime_logging, "enable") == 0)
             runner_add_arg(&runner, "--localtime-logging");
     }