fix(badge): make action, variant and size reactive to state changes #3252
+8
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the Badge component did not update its visual state when the `action`, `variant`, or `size` props were driven by React state. This happened because `withStyleContext` memoized context values and did not trigger a re-render for style context consumers.
Contributor
🚀 Vercel preview deployments triggered successfully!Version:
Projects triggered for preview:- gluestack-ui: https://gluestack-cncc29g5s-geekyants-labs.vercel.app
⏱️ Deployments are building. Check your Vercel dashboard for detailed status.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where the Badge component did not update its style when the action, variant, or size props were changed dynamically through React state.
The problem was caused by the internal style context not re-rendering when these props changed.
This update ensures that the Badge and its children (BadgeText, BadgeIcon) now react properly to prop and state updates — without needing the key workaround.