Add ToDictionarySkipDuplicates - fix duplicate key.

[ricaun]

This pr is related to the issue: #394

[ricaun]

Hey @warappa could you take a look if skip the duplicate key is a valid solution. Thanks.

[warappa]

I think this is fine! 👍

[warappa]

The only question that arises is, if the deep-first-search is then the correct one to do or if in such a case a "top-first-search" would be better. You woukd have to test if the newer System.Text.Json is detected or the older one.

EDIT: But maybe this is not of an issue here, as we compare the AssemblyDefinitions against the previously resolved and passed down AssemblyDefinitions.

[ricaun]

The only question that arises is, if the deep-first-search is then the correct one to do or if in such a case a "top-first-search" would be better. You woukd have to test if the newer System.Text.Json is detected or the older one.

EDIT: But maybe this is not of an issue here, as we compare the AssemblyDefinitions against the previously resolved and passed down AssemblyDefinitions.

Actually is not a System.Text.Json problem, is because I'm repacking the same file 2 times, or two files with the same assembly name.

Like creating a copy of the dll and repack the source and the copy.
ILRepack.exe /allowdup /allowduplicateresources /out:IssueILRepackOut.dll IssueILRepack.dll IssueILRepack.Copy.dll

This trigger the same key in the dictionary. #394

[KirillOsenkov]

assembly.Name.Name is repeated three times, it's good to extract a local variable and reuse it

[ricaun]

Make sense, oh you already changed to the key. Nice!