A11Y : fix issues due to 4.1.0 (Multiple Select2)#24833
Draft
f2cmb wants to merge 4 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
one fixe for Fix dropdowns accessibility roadmap#310 that comes from : build(deps): bump select2 from 4.0.13 to 4.1.0 #24438, as 4.1.0 ships an improvment for a11y (close button is now a real button)
Here is a brief description of what this PR does :
Finishes the 4.1.0 bump from #24438. Kept because the chip's remove control is now a real
<button aria-label="Remove item">(keyboard/screen-reader reachable) instead of a decorative<span>. The raw bump broke our overrides, so I adapted the SCSS to the new chip layout:padding-leftto stop the×overlapping the text,margin-leftrestored so the first chip isn't glued to the left edge, styled the search field (now a<textarea>), and renamed the removedcontainerCssClassoption toselectionCssClass.It's one global rule, no per-screen special-casing. Checked live on Forms, ITIL, Assets and Config: renders as before, minus the overlap. New
dropdown_a11y.spec.tslocks the accessible button (fails on 4.0.13, passes on 4.1.0).Screenshots :