Fix (TicketTask) empty task duration dropdown no longer overrides the planned end date#24811
Open
Herafia wants to merge 2 commits into
Open
Conversation
… planned end date
trasher
approved these changes
Jul 9, 2026
Rom1-B
approved these changes
Jul 9, 2026
Contributor
|
Also, please rebase ti update CI conf |
Co-authored-by: Romain B. <8530352+Rom1-B@users.noreply.github.com>
stonebuzz
approved these changes
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist before requesting a review
Please delete options that are not relevant.
Description
briefdescription of what this PR doesThe task form contains two duration fields that are submitted at the same time during saving:
The duration drop-down list:
actiontimefieldThe schedule
Upon saving,
handleTaskDurationdetermines which one takes precedence. Its rule was:If the duration from the drop-down list differs from the one saved, then it takes precedence, and it recalculates the end date as start date + duration.
The duration drop-down list only offers fixed increments (1 to 9 minutes, then in 5-minute increments, then in hours, etc.). If the task has a duration that does not match any of these increments (for example, 12 minutes), the list cannot display it → it defaults to the empty option “-----,” which sends the value 0.
Upon saving:
list duration (0) ≠ saved duration (e.g., 720 s) → the list “wins”
therefore end = start + 0 = start
therefore start = end → validation fails → ERROR
Now: we only allow the “duration” list to override the end date if an actual duration (> 0) has been selected.
Screenshots (if appropriate):