Store progress indicator into files #19838
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist before requesting a review
Description
Storing the progress indicator into the session was blocking the ability to delegate to the progress storage the responsability of generating a unique key. Indeed, it was not possible to send before the end of the operation using a
flush()operation because we had to play with session open/close state to store the progress and it cannot be done after aflush().Delegating the key generation to the progress storage will permit to be sure that it is impossible to use conflicting keys due to a copied/pasted piece of code or due to the usage of a static key for operations that can be executed in parallel (e.g. massive actions from multiple users).