Do not automatically truncate text fields #19820
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist before requesting a review
Description
Follows #19786.
When a value is truncated by
CommonDBTM::filterValues()
, the triggerred warning will, most of the time, not be seen by the user. The truncated part of the value may be important, for instance for an e-mail, and it is probably preferable to get a clear error rather than an invisible warning.Also, some values may be truncated even if the database field is not limited to 255 chars.
I propose to remove this truncation, in order to trigger a SQL error when the value does not fit into the database field. The input value length should be either limited in the form, or checked by the
prepareInputFor*
methods.