Skip to content

Remove duplicate user_header elements #19742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

cconard96
Copy link
Contributor

Checklist before requesting a review

  • I have read the CONTRIBUTING document.
  • I have performed a self-review of my code.

Description

In both horizontal and vertical menu modes, the user_header.html.twig template is always included twice and set so that when the lg breakpoint is reached, one is hidden while the other appears. I am not able to see any difference in behavior between that and having a single inclusion.

trasher
trasher previously approved these changes May 19, 2025
Copy link
Contributor

@AdrienClairembault AdrienClairembault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't it just meant to be displayed at different breakpoints?

Before:

image

After:

image

@trasher trasher dismissed their stale review May 19, 2025 07:54

nok on some views

@orthagh
Copy link
Contributor

orthagh commented May 19, 2025

Yes, it's exactly for this purpose.
Note, I'm not displeased by the second screenshot, and if everyone agrees, we could move to a single occurrence in the code.

@cedric-anne
Copy link
Member

Yes, it's exactly for this purpose. Note, I'm not displeased by the second screenshot, and if everyone agrees, we could move to a single occurrence in the code.

If the menu still works at this new location on mobile devices, then I am OK with it. Having only one occurence of the menu is preferable.

@cconard96
Copy link
Contributor Author

I don't see the same thing in the After screenshot.

Selection_469

@AdrienClairembault
Copy link
Contributor

AdrienClairembault commented May 19, 2025

If the menu still works at this new location on mobile devices, then I am OK with it. Having only one occurence of the menu is preferable.

I disagree, having a logo alone on the right side feels very disturbing IMO.
While it reduce the code, it is also inconsistent with the desktop UI where the user menu dropdown is on the first line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants