Skip to content

fix(ticket): auto-assign tech with ITIL category launch rule #19694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: 10.0/bugfixes
Choose a base branch
from

Conversation

MyvTsv
Copy link
Contributor

@MyvTsv MyvTsv commented May 12, 2025

  • I have read the CONTRIBUTING document.
  • I have performed a self-review of my code.
  • I have added tests that prove my fix is effective or that my feature works.
  • This change requires a documentation update.

Description

  • It fixes !37648
  • If a technician group or technician is assigned to a ticket via the category, the rules that target this field are not executed, as the rules are executed before the actor field is set by the category.

Screenshots (if appropriate):

Rule:
image

ITILCategory:
image

@MyvTsv MyvTsv self-assigned this May 13, 2025
@MyvTsv MyvTsv requested review from stonebuzz and Rom1-B May 13, 2025 09:11
@stonebuzz
Copy link
Contributor

seems good for me, can you add test ?

@MyvTsv MyvTsv marked this pull request as ready for review May 14, 2025 07:08
@MyvTsv MyvTsv requested review from Rom1-B and stonebuzz May 21, 2025 07:22
@MyvTsv
Copy link
Contributor Author

MyvTsv commented May 21, 2025

It's good for customer

@stonebuzz
Copy link
Contributor

@MyvTsv can fix lint

Copy link
Member

@cedric-anne cedric-anne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This changes the behaviour of GLPI.
First, the auto assign was acting as a fallback. It was assigning tech/group only if none was already assigned. It means that it was not triggered, for instance, if a technician was added by a rule.
Second, it was possible to assign a tech based on a category defined by the rules. Now it will not be possible to do it anymore.
And then, it will change the behaviour of rules based on the assigned technician, and it may produce unexpected results, depending on the purpose of the corresponding rule.

I am not sure we should change it. @orthagh, your opinion?

@Rom1-B Rom1-B self-requested a review May 27, 2025 09:58
@MyvTsv
Copy link
Contributor Author

MyvTsv commented May 28, 2025

@orthagh
I tried the problem again on my side and this is what happened:

I assign a responsible group to a category and create a ticket rule with the group as a trigger that assigns that same group as an observer.

image
image

I create a ticket manually without using formcreator, I assign the category to the ticket and the group assigned to the category is assigned as technician. However, this same group is not the ticket's observer, which should be the case according to the rule.

image

If I create the same ticket, but manually assign the technician group without using the automatic assignment via the category, the rule is activated correctly, and the group also becomes the ticket observer.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants