Dropdowns with complex joins #13289
Merged
Dropdowns with complex joins #13289
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
requires SQL DISTINCT keyword to deduplicate entries; see commit 4040079
btry
force-pushed
the
getdropdowvalue_requires_distinct
branch
from
8777eda to
f4ba45b
Compare
2 tasks
cedric-anne
approved these changes
Nov 15, 2022
trasher
approved these changes
Nov 15, 2022
Contributor
trasher
left a comment
trasher
left a comment
There was a problem hiding this comment.
Sounds good to me, but I cannot say if that can cause any issue
orthagh
approved these changes
Nov 15, 2022
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
requires SQL DISTINCT keyword to deduplicate entries; see commit 4040079
In Formcreator's incoming feature to filter dropdowns (GLPI object or dropdown question types) items may e duplicated when a search filter is implemented.
To reproduce :
Use Formcreator branch support/2.14.0 with PR pluginsGLPI/formcreator#2978 (and dependencies in GLPI; see its description)
The problem comes from the lack of DISTINCT in the query which feeds the dropdown, via Dropdown::getDropdownValue() because such filter adds LEFT JOIN clauses.