Tabs in modals #12637
Merged
Tabs in modals #12637
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orthagh
approved these changes
Sep 13, 2022
trasher
approved these changes
Sep 13, 2022
cedric-anne
approved these changes
Sep 14, 2022
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Formcreator features are constantly growing. The questions design system becomes messy because there are too many settings.
As dropping the modal to design a question is very likely a bad idea, I'm experimenting the use of tabs in a modal. See below:
This PR allows to not render the navigation header we can see in the top of the modal. Going back to a list of items is not relevant here and pollutes the modal.