give itemtype the ability to modify their data before add #12615
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
btry
requested review from
AdrienClairembault,
cedric-anne,
orthagh and
trasher
trasher
approved these changes
Sep 9, 2022
orthagh
approved these changes
Sep 9, 2022
trasher
reviewed
Sep 9, 2022
cedric-anne
reviewed
Sep 9, 2022
Member
cedric-anne
left a comment
cedric-anne
left a comment
There was a problem hiding this comment.
Could you please add an entry in the changelog, in ### API changes > #### Added section ?
see pre_updateInDB()
cedric-anne
reviewed
Sep 9, 2022
cedric-anne
approved these changes
Sep 9, 2022
AdrienClairembault
approved these changes
Sep 9, 2022
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to CommonDBTM::pre_updateInDB()
A use case would be the management of a complex data which is hard / useless to store il multiple fields. It could be JSON encoded in a single field of the DB, but for manipulation should be decoded.
Combined with post_getFromDB and pre_updateInDb(), the new method pre_addInDB() could handle the JSON encode/decode process without hassle, maintaining in RAM the data as an array or an object, at developer's convenience.