-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Zenodo. #903
Remove Zenodo. #903
Conversation
Codecov Report
@@ Coverage Diff @@
## main #903 +/- ##
==========================================
- Coverage 86.64% 86.60% -0.05%
==========================================
Files 41 41
Lines 4575 4575
Branches 996 996
==========================================
- Hits 3964 3962 -2
- Misses 431 432 +1
- Partials 180 181 +1 see 3 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
It looks like |
The siganc developer team is free to track citations however they wish. |
No strong opinion, so I say we just leave it as is until we have a reason to do something else. I think maintaining a simpler text format would also be fine, but no value add in converting now. |
CITATION.cff
Outdated
@@ -9,7 +9,7 @@ abstract: | | |||
a well-defined indexable storage layout for data and metadata. This makes it easier to | |||
operate on large data spaces, streamlines post-processing and analysis and makes data | |||
collectively accessible. | |||
doi: 10.5281/zenodo.2581327 | |||
doi: "10.1016/j.commatsci.2018.01.035" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure that this is right. We want a citation for the software here, so I think we just remove the doi. It's already included in the article section below.
pyproject.toml
Outdated
@@ -80,7 +80,7 @@ skip_glob = 'signac/_vendor/*' | |||
|
|||
[tool.pydocstyle] | |||
convention = "numpy" | |||
match = "^((?!\\.sync-zenodo-metadata|setup).)*\\.py$" | |||
match = "^((?!setup).)*\\.py$" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not technically in scope, but since we're modifying this line anyway I think we can get rid of it entirely now. We don't have a setup.py file anymore.
Description
This PR removes Zenodo metadata.
Motivation and Context
We haven't been updating the Zenodo records for signac (last updated February 2019). To simplify the repository, we can remove this. Discussed offline with @csadorf @vyasr.
cc: @joaander in case this affects how we track citation statistics. We may also remove the Zenodo reference from https://docs.signac.io/en/latest/acknowledge.html.
Checklist: