Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Move hashing.calc_id into the job module. The parameter is also renamed from
spec
tostatepoint
to more accurately reflect its usage.Motivation and Context
The id computed by
hashing.calc_id
is not a generic hash id. It is very specifically tied to the project-job-statepoint relationship that forms the core data model in signac. This move helps clarify that. Additionally, if we ever move to support more general file layouts, this move ensures that the calculated id is tightly coupled to the Job class.Checklist: