Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make _DictManager private. #858

Merged
merged 3 commits into from
Nov 7, 2022
Merged

Make _DictManager private. #858

merged 3 commits into from
Nov 7, 2022

Conversation

bdice
Copy link
Member

@bdice bdice commented Nov 6, 2022

Description

This PR makes _DictManager private. Addresses a TODO in the code.

Checklist:

@bdice bdice requested review from a team as code owners November 6, 2022 21:41
@bdice bdice requested review from csadorf and klywang and removed request for a team November 6, 2022 21:41
@bdice bdice self-assigned this Nov 6, 2022
@bdice bdice added the refactor Code refactoring label Nov 6, 2022
@bdice bdice added this to the v2.0.0 milestone Nov 6, 2022
@codecov
Copy link

codecov bot commented Nov 6, 2022

Codecov Report

Merging #858 (6f9ba48) into master (bd65753) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #858   +/-   ##
=======================================
  Coverage   85.07%   85.07%           
=======================================
  Files          50       50           
  Lines        4669     4669           
  Branches      924      924           
=======================================
  Hits         3972     3972           
  Misses        518      518           
  Partials      179      179           
Impacted Files Coverage Δ
signac/core/dict_manager.py 88.37% <100.00%> (ø)
signac/core/h5store.py 91.03% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@bdice bdice mentioned this pull request Nov 6, 2022
6 tasks
@vyasr vyasr enabled auto-merge (squash) November 6, 2022 23:53
@vyasr vyasr merged commit 880a28a into master Nov 7, 2022
@vyasr vyasr deleted the make-dictmanager-private branch November 7, 2022 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Code refactoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants