Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error on invalid config data #855

Merged
merged 4 commits into from
Nov 6, 2022
Merged

Error on invalid config data #855

merged 4 commits into from
Nov 6, 2022

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Nov 6, 2022

Description

This PR changes the behavior of signac when an invalid log file is detected. Rather than just logging a debug-level error, it raises an exception.

Motivation and Context

An invalid config can lead to numerous other internal issues and is better to be raised loudly.

Checklist:

@vyasr vyasr added this to the v2.0.0 milestone Nov 6, 2022
@vyasr vyasr self-assigned this Nov 6, 2022
@vyasr vyasr requested review from a team as code owners November 6, 2022 18:05
@vyasr vyasr requested review from kidrahahjo and shihkual and removed request for a team November 6, 2022 18:05
@codecov
Copy link

codecov bot commented Nov 6, 2022

Codecov Report

Merging #855 (cb13068) into master (6390077) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master     #855   +/-   ##
=======================================
  Coverage   85.02%   85.02%           
=======================================
  Files          50       50           
  Lines        4668     4668           
  Branches      924      924           
=======================================
  Hits         3969     3969           
  Misses        519      519           
  Partials      180      180           
Impacted Files Coverage Δ
signac/common/config.py 89.39% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@bdice bdice force-pushed the feature/config_error branch from aef3efb to 96b1af7 Compare November 6, 2022 20:03
@bdice bdice enabled auto-merge (squash) November 6, 2022 20:26
@bdice bdice merged commit 7f2297d into master Nov 6, 2022
@bdice bdice deleted the feature/config_error branch November 6, 2022 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants