-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use FutureWarning instead of DeprecationWarning in project.py #691
Conversation
Codecov Report
@@ Coverage Diff @@
## master #691 +/- ##
==========================================
+ Coverage 78.53% 78.54% +0.01%
==========================================
Files 65 65
Lines 7141 7141
Branches 1565 1565
==========================================
+ Hits 5608 5609 +1
Misses 1228 1228
+ Partials 305 304 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Onkar627, thank you for the pull request! It looks like the changes in this PR are good. I have a few requests for this PR before merging:
- An important part of the pull request process is to include descriptions of what was changed and why. Descriptions and references to related issues helps reviewers and PR authors communicate effectively. Would you be able to write some description/motivation information in the top section of the PR description? Please include a link to the issue Use FutureWarning to report deprecations #687. Look at past pull requests for examples of what kinds of information to write.
- Please rename this PR to "Use
FutureWarning
instead ofDeprecationWarning
in project.py" so that the intention of the pull request is clear. - Look over the PR checklist and mark the appropriate boxes. For example, this PR would probably be considered a "New feature." Additionally, you need to read over and check the boxes below that to acknowledge that you have read the contributing guidelines, agree to the contributor agreement, have added yourself to the contributor list, etc.
I have updated the PR @bdice ,please have a look and just ping if any changes are required :) |
@Onkar627 Thank you! If you would like, please consider adding yourself to the list of contributors. I'll add a changelog entry, and then merge this PR after you add yourself to the contributor list (you may decline if you'd rather not add yourself). We will use the same changelog entry for #692, and just add the number of that PR in the same line. |
Surely,I will love to add. |
Description
Fixes issues as described by @vyasr in Issue #687 as we tend to change the DeprecationWarning to FutureWarning instead.
Motivation and Context
The main motivation of this change is basically that warnings of the deprecated features are visible to the users as in current scenarios of Deprecated warnings python hides these by default.
Types of Changes
1The change breaks (or has the potential to break) existing functionality.
Checklist:
If necessary: