-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Raise error on underspecified path for import/export and view #666
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Co-authored-by: Corwin Kerr <cbkerr@umich.edu>
for more information, see https://pre-commit.ci
Codecov Report
@@ Coverage Diff @@
## master #666 +/- ##
==========================================
+ Coverage 78.40% 78.42% +0.02%
==========================================
Files 65 65
Lines 7112 7120 +8
Branches 1561 1564 +3
==========================================
+ Hits 5576 5584 +8
Misses 1226 1226
Partials 310 310
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a couple small suggestions. Otherwise this looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @cbkerr. I pushed some changes and will set this to automerge once CI passes.
Description
Just the bug fix.
There is some duplicate code, but that will be refactored in the rest of #642.
Motivation and Context
see #642 for a description
Types of Changes
1The change breaks (or has the potential to break) existing functionality.
Checklist:
If necessary: