Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise error on underspecified path for import/export and view #666

Merged
merged 35 commits into from
Jan 23, 2022

Conversation

cbkerr
Copy link
Member

@cbkerr cbkerr commented Jan 21, 2022

Description

Just the bug fix.

There is some duplicate code, but that will be refactored in the rest of #642.

Motivation and Context

see #642 for a description

Types of Changes

  • Documentation update
  • Bug fix
  • New feature
  • Breaking change1

1The change breaks (or has the potential to break) existing functionality.

Checklist:

If necessary:

  • I have updated the API documentation as part of the package doc-strings.
  • I have created a separate pull request to update the framework documentation on signac-docs and linked it here.
  • I have updated the changelog and added all related issue and pull request numbers for future reference (if applicable). See example below.

@cbkerr cbkerr requested review from a team as code owners January 21, 2022 19:51
@cbkerr cbkerr requested review from tcmoore3 and lyrivera and removed request for a team January 21, 2022 19:51
@codecov
Copy link

codecov bot commented Jan 21, 2022

Codecov Report

Merging #666 (6e29705) into master (8176ba9) will increase coverage by 0.02%.
The diff coverage is 100.00%.

❗ Current head 6e29705 differs from pull request most recent head fa86a4e. Consider uploading reports for the commit fa86a4e to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #666      +/-   ##
==========================================
+ Coverage   78.40%   78.42%   +0.02%     
==========================================
  Files          65       65              
  Lines        7112     7120       +8     
  Branches     1561     1564       +3     
==========================================
+ Hits         5576     5584       +8     
  Misses       1226     1226              
  Partials      310      310              
Impacted Files Coverage Δ
signac/contrib/linked_view.py 83.91% <ø> (ø)
signac/contrib/import_export.py 78.36% <100.00%> (+0.46%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8176ba9...fa86a4e. Read the comment docs.

@cbkerr cbkerr mentioned this pull request Jan 21, 2022
12 tasks
Copy link
Member

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a couple small suggestions. Otherwise this looks good.

@cbkerr cbkerr requested a review from bdice January 22, 2022 18:10
Copy link
Member

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cbkerr. I pushed some changes and will set this to automerge once CI passes.

@bdice bdice enabled auto-merge (squash) January 23, 2022 19:12
@bdice bdice merged commit 44f59ee into master Jan 23, 2022
@bdice bdice deleted the fix/view-nonunique branch January 23, 2022 19:29
@b-butler b-butler added this to the v1.8.0 milestone Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants