Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove easily deprecated functions from project.py #574

Merged
merged 12 commits into from
Jul 28, 2021
Merged

Remove easily deprecated functions from project.py #574

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
5234d12
beginning to pull out deprecated from project.py
atravitz Jul 19, 2021
8f75e5b
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jul 19, 2021
061b167
Revert "[pre-commit.ci] auto fixes from pre-commit.com hooks"
atravitz Jul 23, 2021
9090a99
Revert "beginning to pull out deprecated from project.py"
atravitz Jul 23, 2021
affaa63
removing deprecated get_id()
atravitz Jul 23, 2021
184a310
removing deprecated get_id() from project.py
atravitz Jul 23, 2021
d628fbc
updating more instances of project.get_id()
atravitz Jul 23, 2021
43a67df
removing index building methods
atravitz Jul 23, 2021
0ebf48a
removing access module and reset/update statepoint from project.py
atravitz Jul 23, 2021
a4f4fed
Simplify benchmark setup code for readability (no observed impact on …
bdice Jul 24, 2021
d1f5d7f
Remove tests that are exact duplicates.
bdice Jul 24, 2021
ae40887
Add missing test cases for test_find_jobs from the removed function t…
bdice Jul 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions benchmark.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,17 +218,16 @@ def run(key, timer, repeat=3, number=10):
"search_lean_filter",
Timer(
stmt="len(project.find_jobs(f))",
setup=setup + "sp = project.open_job(id=random.choice(list(project"
".find_job_ids()))).statepoint(); k, v = sp.popitem(); f = {k: v}",
setup=setup + "sp = random.choice(list(project.find_jobs())).statepoint(); "
"k, v = sp.popitem(); f = {k: v}",
),
)

run(
"search_rich_filter",
Timer(
stmt="len(project.find_jobs(f))",
setup=setup + "f = project.open_job(id=random.choice(list"
"(project.find_job_ids()))).statepoint()",
setup=setup + "f = random.choice(list(project.find_jobs())).statepoint()",
),
)

Expand Down
6 changes: 0 additions & 6 deletions doc/api.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,23 +17,18 @@ The Project

.. autosummary::

Project.build_job_search_index
Project.build_job_statepoint_index
Project.check
Project.clone
Project.config
Project.create_access_module
Project.create_linked_view
Project.detect_schema
Project.data
Project.doc
Project.document
Project.dump_statepoints
Project.export_to
Project.find_job_ids
Project.find_jobs
Project.fn
Project.get_id
Project.get_statepoint
Project.groupby
Project.groupbydoc
Expand All @@ -46,7 +41,6 @@ The Project
Project.open_job
Project.read_statepoints
Project.repair
Project.reset_statepoint
Project.root_directory
Project.stores
Project.sync
Expand Down
9 changes: 1 addition & 8 deletions signac/__main__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,10 +249,6 @@ def find_with_filter(args):
def main_project(args):
"""Handle project subcommand."""
project = get_project()
if args.access:
fn = project.create_access_module()
_print_err(f"Created access module '{fn}'.")
return
if args.index:
for doc in project.index():
print(json.dumps(doc))
Expand Down Expand Up @@ -655,7 +651,7 @@ def _main_import_interactive(project, origin, args):
banner=SHELL_BANNER_INTERACTIVE_IMPORT.format(
python_version=sys.version,
signac_version=__version__,
project_id=project.get_id(),
project_id=project.id,
job_banner="",
root_path=project.root_directory(),
workspace_path=project.workspace(),
Expand Down Expand Up @@ -1223,9 +1219,6 @@ def main():
action="store_true",
help="Generate and print an index for the project.",
)
parser_project.add_argument(
"-a", "--access", action="store_true", help="Create access module for indexing."
)
parser_project.set_defaults(func=main_project)

parser_job = subparsers.add_parser("job")
Expand Down
Loading