Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add oldest & minimal CI configurations. #474

Merged
merged 19 commits into from
Jan 22, 2021
Merged

Add oldest & minimal CI configurations. #474

merged 19 commits into from
Jan 22, 2021

Conversation

bdice
Copy link
Member

@bdice bdice commented Jan 21, 2021

Description

  • Adds "oldest" CI configuration. Python 3.6 is no longer supported by the latest versions of our testing dependencies.
  • Adds "minimal" CI configuration with Python 3.9, to ensure that our package's hard requirements are enough to pass tests (and ensure that users who don't have the optional dependencies installed can still use the package's core features).
  • Re-organizes all the CI requirements files into a subdirectory called requirements.

The "oldest" changes are discussed in PR #460, which this supersedes. I talked through the process of this PR with @atravitz and @kidrahahjo during signac office hours.

Types of Changes

  • Documentation update
  • Bug fix
  • New feature
  • Breaking change1

1The change breaks (or has the potential to break) existing functionality.

Checklist:

If necessary:

  • I have updated the API documentation as part of the package doc-strings.
  • I have created a separate pull request to update the framework documentation on signac-docs and linked it here.
  • I have updated the changelog and added all related issue and pull request numbers for future reference (if applicable). See example below.

@bdice bdice requested review from a team as code owners January 21, 2021 18:45
@bdice bdice requested review from kidrahahjo and klywang and removed request for a team January 21, 2021 18:45
@codecov
Copy link

codecov bot commented Jan 21, 2021

Codecov Report

Merging #474 (d2bceb7) into master (d4f2121) will increase coverage by 0.10%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #474      +/-   ##
==========================================
+ Coverage   77.08%   77.18%   +0.10%     
==========================================
  Files          42       42              
  Lines        5768     5768              
  Branches     1129     1129              
==========================================
+ Hits         4446     4452       +6     
+ Misses       1034     1030       -4     
+ Partials      288      286       -2     
Impacted Files Coverage Δ
signac/core/synceddict.py 96.01% <0.00%> (+1.32%) ⬆️
signac/core/json.py 84.00% <0.00%> (+12.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4f2121...d2bceb7. Read the comment docs.

@bdice bdice added this to the v1.6.0 milestone Jan 21, 2021
@bdice bdice added the dependencies Pull requests that update a dependency file label Jan 21, 2021
@bdice bdice self-assigned this Jan 21, 2021
@bdice bdice force-pushed the ci/oldest branch 2 times, most recently from 1fe6e29 to a51fff5 Compare January 21, 2021 21:11
@bdice bdice changed the title Add oldest CI config for Python 3.6. Add oldest & minimal CI configurations. Jan 21, 2021
Copy link
Collaborator

@kidrahahjo kidrahahjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will make the same changes for flow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants