Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize H5Store init. #443

Merged
merged 5 commits into from
Jan 5, 2021
Merged

Optimize H5Store init. #443

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f2c18bf
Use abspath instead of realpath for H5Store filenames (faster, and it…
bdice Dec 22, 2020
07cbea0
Update changelog.
bdice Dec 22, 2020
28bddf9
Merge branch 'master' into feature/optimize-h5store-init
bdice Dec 29, 2020
2b7bff5
Merge branch 'master' into feature/optimize-h5store-init
vyasr Jan 5, 2021
8ec81e1
Merge branch 'master' into feature/optimize-h5store-init
vyasr Jan 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ Changed
+++++++

- Optimized job hash and equality checks (#442).
- Optimized ``H5Store`` initialization (#443).
- State points are loaded lazily when ``Job`` is opened by id (#238, #239).


Expand Down
2 changes: 1 addition & 1 deletion signac/core/h5store.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -327,7 +327,7 @@ class H5Store(MutableMapping):
def __init__(self, filename, **kwargs):
if not (isinstance(filename, str) and len(filename) > 0):
raise ValueError("H5Store filename must be a non-empty string.")
self._filename = os.path.realpath(filename)
self._filename = os.path.abspath(filename)
self._file = None
self._kwargs = kwargs

Expand Down