Drop Support for Python 3.5

[vishav1771]

Description

This PR drops support for Python 3.5. I have removed CI tests, updated do and updated setup.py

Motivation and Context

#336

Types of Changes

• Documentation update
• Bug fix
• New feature
• Breaking change¹

¹The change breaks (or has the potential to break) existing functionality.

Checklist:

• I am familiar with the Contributing Guidelines.
• I agree with the terms of the Contributor Agreement.
• My name is on the list of contributors.
• My code follows the code style guideline of this project.
• The changes introduced by this pull request are covered by existing or newly introduced tests.

If necessary:

• I have updated the API documentation as part of the package doc-strings.
• I have created a separate pull request to update the framework documentation on signac-docs and linked it here.
• I have updated the changelog and added all related issue and pull request numbers for future reference (if applicable). See example below.

Example for a changelog entry: Fix issue with launching rockets to the moon (#101, #212).

[codecov]

Codecov Report

Merging #340 into master will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #340      +/-   ##
==========================================
- Coverage   76.24%   76.22%   -0.03%     
==========================================
  Files          43       43              
  Lines        7103     7096       -7     
==========================================
- Hits         5416     5409       -7     
  Misses       1687     1687              

Impacted Files	Coverage Δ
signac/contrib/collection.py	88.97% <100.00%> (-0.09%)	⬇️
signac/contrib/import_export.py	84.63% <100.00%> (-0.13%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 842a07f...72ede7a. Read the comment docs.

[bdice]

@vishav1771 I also searched the codebase and found a couple things you might have missed:

signac/signac/contrib/import_export.py

Line 546 in 842a07f

if sys.version_info < (3, 6):

signac/signac/contrib/collection.py

Line 925 in 842a07f

if sys.version_info < (3, 6):

I found these by searching the codebase for version and 3.*6 and 3.*5 and filtering non-matches.

Please also remove these outdated conda testing scripts, since we no longer support any Python version listed in them. 😆

• https://github.com/glotzerlab/signac/blob/master/tests/conda_create_config_host_test_env.sh
• https://github.com/glotzerlab/signac/blob/master/tests/conda_create_test_env.sh

Otherwise this looks good to me! I'll let @atravitz and @jennyfothergill review/approve/finalize. Thanks. 👍

[csadorf]

Are we planning to have no releases anymore before EOL Py3.5? Then this should not go into master. I think that in general there should be a discussion over the supported Python minor versions.

[bdice]

@csadorf I may have misunderstood your comment earlier that prompted this - I thought you were in support of dropping 3.5 because. EOL is soon, but we could make one more release if you think it is necessary. Let’s discuss adhering to NEP 29, which I linked on the other discussion.

[csadorf]

@csadorf I may have misunderstood your comment earlier that prompted this - I thought you were in support of dropping 3.5 because. EOL is soon, but we could make one more release if you think it is necessary. Let’s discuss adhering to NEP 29, which I linked on the other discussion.

My other comment was targeted to ensure that we don't expand efforts to support Py 35 for that specific feature development.

I might have missed the other discussion. I think sticking to NEP 29 is a very good idea, but we should make that explicit somewhere. Support/non-support for Python versions must be handled very transparently both for users and developers IMO.

[mikemhenry]

Dropping python3.5 will let us update pandas to the 1.x line, but I do think we need a more discussion about what the last release will be to support python3.5

[bdice]

Following our dev meeting discussion on Monday, I will update this PR to document that we follow NEP 29. I think that is best done in the same PR but let me know if you disagree.

[csadorf]

Following our dev meeting discussion on Monday, I will update this PR to document that we follow NEP 29. I think that is best done in the same PR but let me know if you disagree.

That's fine, no need to over-engineer.

[bdice]

I have updated this PR to document that we now follow NEP 29. @atravitz @jennyfothergill @csadorf I think it's ready for review. Thanks for this contribution @vishav1771!

[bdice]

Reviewers: ignore the failing test on pypy. This will be handled after this PR and #341 are merged.

[bdice]

I have reviewed and approve this PR.