-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/make project config immutable #246
Conversation
Codecov Report
@@ Coverage Diff @@
## master #246 +/- ##
==========================================
+ Coverage 64.89% 64.96% +0.06%
==========================================
Files 39 39
Lines 5569 5580 +11
==========================================
+ Hits 3614 3625 +11
Misses 1955 1955
Continue to review full report at Codecov.
|
… deprecation that will fail after 2.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added a few straight-forward suggestions, but otherwise it looks good to me! Thank's a lot!
Description
Makes the project config immutable. Note that I had to make the
_mutable
attribute set after construction because the constructor ofConfigObj
calls__setitem__
internally, so constructing theProjectConfig
object would always throw warnings (or error in the future). I'm open to alternative suggestions on how to resolve that.Motivation and Context
Resolves #81, supersedes #244
Types of Changes
1The change breaks (or has the potential to break) existing functionality.
Checklist:
If necessary: