-
Notifications
You must be signed in to change notification settings - Fork 45
Validate Requires-Python metadata against the "mindeps" build in CI config #809
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
c5b0d1a
Add a script to get Requires-Python metadata
sirosen cab7711
Add a check that mindeps CI tests Requires-Python
sirosen d6c2b2a
Put the 'get_python_requires' venv cache in .tox/
sirosen 56485c9
Add 'check-min-python-is-tested' to CI
sirosen becf3f0
Replace get_python_requires.py with 'mddj'
sirosen b113409
ensure_min_python_is_tested checks tox versions
sirosen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,63 @@ | ||
| # this script should only be called via | ||
| # tox run -e check-min-python-is-tested | ||
| # | ||
| # no other usages are supported | ||
| import pathlib | ||
| import subprocess | ||
| import sys | ||
|
|
||
| import ruamel.yaml | ||
|
|
||
| YAML = ruamel.yaml.YAML(typ="safe") | ||
| REPO_ROOT = pathlib.Path(__file__).parent.parent | ||
|
|
||
| proc = subprocess.run( | ||
| ["python", "-m", "mddj", "read", "requires-python", "--lower-bound"], | ||
| check=True, | ||
| capture_output=True, | ||
| cwd=REPO_ROOT, | ||
| ) | ||
| requires_python_version = proc.stdout.decode().strip() | ||
|
|
||
| with open(REPO_ROOT / ".github" / "workflows" / "build.yaml") as f: | ||
| workflow = YAML.load(f) | ||
| try: | ||
| test_mindeps_job = workflow["jobs"]["test-mindeps"] | ||
| except KeyError: | ||
| raise ValueError("Could not find the test-mindeps job. Perhaps it has moved?") | ||
|
|
||
| job_steps = test_mindeps_job["steps"] | ||
| for step in job_steps: | ||
| if "uses" in step and "actions/setup-python" in step["uses"]: | ||
| setup_python_step = step | ||
| break | ||
| else: | ||
| raise ValueError("Could not find the setup-python step.") | ||
|
|
||
| python_version = setup_python_step["with"]["python-version"] | ||
| if python_version != requires_python_version: | ||
| print("ERROR: ensure_min_python_is_tested.py failed!") | ||
| print( | ||
| f"\nPackage data sets 'Requires-Python: >={requires_python_version}', " | ||
| f"but the test-mindeps job is configured to test '{python_version}'.\n", | ||
| file=sys.stderr, | ||
| ) | ||
| sys.exit(1) | ||
|
|
||
|
|
||
| proc = subprocess.run( | ||
| ["python", "-m", "mddj", "read", "tox", "min-version"], | ||
| check=True, | ||
| capture_output=True, | ||
| cwd=REPO_ROOT, | ||
| ) | ||
| tox_min_python_version = proc.stdout.decode().strip() | ||
| if tox_min_python_version != requires_python_version: | ||
| print("ERROR: ensure_min_python_is_tested.py failed!") | ||
| print( | ||
| f"\nPackage data sets 'Requires-Python: >={requires_python_version}', " | ||
| "but tox is configured to test with a minimum of " | ||
| f"'{tox_min_python_version}'.\n", | ||
| file=sys.stderr, | ||
| ) | ||
| sys.exit(1) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.