Update the Client Credentials Example for v4 #1346
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This example still omitted the requested scopes for client credentials and relied on the default (which was removed in v4). Also swap in our symbolic constants from the TransferClient class, rather than the exact strings needed.
sirosen
requested review from
MaxTueckeGlobus,
aaschaer,
ada-globus,
derek-globus,
kurtmckee and
m1yag1
as code owners
m1yag1
approved these changes
Nov 26, 2025
Contributor
m1yag1
left a comment
m1yag1
left a comment
There was a problem hiding this comment.
I copied the examples down verbatim and ran them as a user would. It all worked!
docs/examples/client_credentials.rst
Outdated
| # the secret, loaded from wherever you store it | ||
| CLIENT_SECRET = "..." | ||
| client = globus_sdk.ConfidentialAppAuthClient(CLIENT_ID, CLIENT_SECRET) |
Contributor
There was a problem hiding this comment.
In the example below, "Using ClientCredentialsAuthorizer", we use confidential_client instead of client. The experience may be better if they were consistent. I noticed this when copying and pasting the example text and trying to get everything working as a user would. If both are either confidential_client or client, whichever is better, then both examples work together without needing to rename variables.
Member
Author
There was a problem hiding this comment.
Good callout! Let me tweak it. I think confidential_client in both snippets for the sake of clarity.
- rename `client` to `confidential_client` for consistency - simplify some old-style string formatting using f-strings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This example still omitted the requested scopes for client credentials and relied on the default (which was removed in v4).
Also swap in our symbolic constants from the TransferClient class, rather than the exact strings needed.
Hat tip to @jweirich-globus for spotting this! 🎉