Update warn_deprecated to emit RemovedInV5Warning
#1295
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m1yag1
requested review from
MaxTueckeGlobus,
aaschaer,
ada-globus,
derek-globus,
kurtmckee and
sirosen
as code owners
m1yag1
force-pushed
the
sc-43139-update-warn-deprecated
branch
from
5ba976f to
8dd7040
Compare
kurtmckee
approved these changes
Jul 31, 2025
sirosen
requested changes
Jul 31, 2025
Member
sirosen
left a comment
sirosen
left a comment
There was a problem hiding this comment.
Basically ready to hit approve, but I'm being fussy about the changelog.
changelog.d/20250731_113700_8730430+m1yag1_sc_43139_update_warn_deprecated.rst
Outdated
Show resolved
Hide resolved
sirosen
approved these changes
Jul 31, 2025
m1yag1
force-pushed
the
sc-43139-update-warn-deprecated
branch
from
5157a55 to
b22410d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shortcut Link: https://app.shortcut.com/globus/story/43139
What
Update
warn_deprecatedto emitRemovedInV5Warningand removeRemovedInV4Warningclass.Why
SDK 4.x should use V5 deprecation warnings, not V4 warnings.
How
Replace
RemovedInV4WarningwithRemovedInV5Warningclass and update function usage.📚 Documentation preview 📚: https://globus-sdk-python--1295.org.readthedocs.build/en/1295/