Remove SearchClient.create_entry #1293
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sirosen
requested review from
MaxTueckeGlobus,
aaschaer,
ada-globus,
derek-globus,
kurtmckee and
m1yag1
as code owners
ada-globus
approved these changes
Jul 29, 2025
Contributor
ada-globus
left a comment
ada-globus
left a comment
There was a problem hiding this comment.
Should we add a mention in the upgrading guide?
Member
Author
|
I thought about it, but I don't know if it's worth it? I guess we can, for this and |
Contributor
|
Yeah, I think it costs us little and is a nice affordance to the user. I don't think much copy is needed—effectively just an english language redirect (since nothing else in v4 will tell them where to go... the signpost is removed with this change!) |
sirosen
force-pushed
the
remove-create-entry
branch
from
e221186 to
acbbf22
Compare
Member
Author
|
Since this needed a rebase anyway, I've included the doc here rather than splitting it to a separate PR. |
sirosen
force-pushed
the
remove-create-entry
branch
from
acbbf22 to
0fbe6e3
Compare
sirosen
force-pushed
the
remove-create-entry
branch
from
0fbe6e3 to
b85c0f0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Documentation preview 📚: https://globus-sdk-python--1293.org.readthedocs.build/en/1293/