Skip to content

Remove the ComputeClient alias #1282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sirosen merged 1 commit into from
Jul 23, 2025
Merged

Remove the ComputeClient alias #1282

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions changelog.d/20250723_155826_sirosen_remove_compute_client.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
Removed
-------

- Removed the ``ComputeClient`` alias. This name was deprecated in
``globus-sdk`` version 3. Users should use ``ComputeClientV2`` or
``ComputeClientV3`` instead. (:pr:`NUMBER`)
10 changes: 0 additions & 10 deletions docs/services/compute.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,16 +37,6 @@ supports the latest API features and improvements.
.. listknownscopes:: globus_sdk.scopes.ComputeScopes
:base_name: ComputeClientV3.scopes


.. py:class:: ComputeClient

A deprecated alias for :class:`ComputeClientV2`.

.. warning::

This class will be removed in ``globus-sdk`` version 4.
Users should migrate to one of the explicitly-versioned classes.

Client Errors
-------------

Expand Down
2 changes: 0 additions & 2 deletions src/globus_sdk/__init__.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,6 @@ from .services.compute import (
ComputeFunctionDocument,
ComputeFunctionMetadata,
)
from .services.compute.deprecated_client import ComputeClient
from .services.flows import (
FlowsAPIError,
FlowsClient,
Expand Down Expand Up @@ -177,7 +176,6 @@ __all__ = (
"OAuthTokenResponse",
"IDTokenDecoder",
"ComputeAPIError",
"ComputeClient",
"ComputeClientV2",
"ComputeClientV3",
"ComputeFunctionDocument",
Expand Down
32 changes: 0 additions & 32 deletions src/globus_sdk/services/compute/deprecated_client.py
View file
Open in desktop

This file was deleted.

27 changes: 0 additions & 27 deletions tests/unit/services/compute/test_deprecated_client_alias.py
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion tests/unit/test_lazy_imports.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ def test_explicit_dir_func_works():
assert "__all__" in dir(globus_sdk)


@pytest.mark.filterwarnings("ignore::globus_sdk.RemovedInV4Warning")
def test_force_eager_imports_can_run():
# this check will not do much, other than ensuring that this does not crash
globus_sdk._force_eager_imports()
Expand Down
15 changes: 6 additions & 9 deletions tests/unit/test_paginator_signature_matching.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,21 +4,18 @@
"""

import inspect
import warnings

import pytest

import globus_sdk

_CLIENTS_TO_CHECK = []
with warnings.catch_warnings():
warnings.simplefilter("ignore", category=globus_sdk.RemovedInV4Warning)
for attrname in dir(globus_sdk):
obj = getattr(globus_sdk, attrname)
if obj is globus_sdk.BaseClient:
continue
if isinstance(obj, type) and issubclass(obj, globus_sdk.BaseClient):
_CLIENTS_TO_CHECK.append(obj)
for attrname in dir(globus_sdk):
obj = getattr(globus_sdk, attrname)
if obj is globus_sdk.BaseClient:
continue
if isinstance(obj, type) and issubclass(obj, globus_sdk.BaseClient):
_CLIENTS_TO_CHECK.append(obj)

_METHODS_TO_CHECK = []
for cls in _CLIENTS_TO_CHECK:
Expand Down
Loading