Remove the compatibility shim from create_policy
#1257
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sirosen
requested review from
MaxTueckeGlobus,
ada-globus,
derek-globus,
kurtmckee and
m1yag1
as code owners
kurtmckee
reviewed
Jul 14, 2025
| return GetPoliciesResponse(self.get("/v2/api/policies")) | ||
|
|
||
| @_create_policy_compat | ||
| def create_policy( # pylint: disable=missing-param-doc |
Member
There was a problem hiding this comment.
Is there any chance that removing the shim means that the pylint disable comment can be removed as well? Or is that pylint issue unrelated?
Member
Author
There was a problem hiding this comment.
I missed that; not only is it not needed, I don't think it was needed before this change either!
Documentation order now matches declaration order.
kurtmckee
approved these changes
Jul 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Documentation preview 📚: https://globus-sdk-python--1257.org.readthedocs.build/en/1257/