Update search client classes to use MISSING defaults #1207
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxTueckeGlobus
requested review from
aaschaer,
ada-globus,
derek-globus,
kurtmckee,
m1yag1 and
sirosen
as code owners
kurtmckee
requested changes
Jun 3, 2025
changelog.d/20250603_130159_max.tuecke_sc_15807_search_missing_defaults.rst
Outdated
Show resolved
Hide resolved
sirosen
reviewed
Jun 3, 2025
kurtmckee
reviewed
Jun 4, 2025
kurtmckee
approved these changes
Jun 4, 2025
sirosen
approved these changes
Jun 5, 2025
| add_kwargs["limit"] = limit | ||
| if add_kwargs: | ||
| data = {**data, **add_kwargs} | ||
| data = {**data, **add_kwargs} |
Member
There was a problem hiding this comment.
I'm going to continue to think about this case, but we don't need to solve it right now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sc-15807
This PR is for SDKv4 and is a followup to #1205.
Changes
Nonetoglobus_sdk.MISSINGfor payload types in the search client.MISSINGdefaults instead ofNone.Search OpenAPI spec for reference.
📚 Documentation preview 📚: https://globus-sdk-python--1207.org.readthedocs.build/en/1207/