Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
Removed
~~~~~~~

- Deprecated aliases for ``TimersClient``, ``TimersScopes``, and
``TimersAPIError`` have been removed. (:pr:`NUMBER`)
4 changes: 0 additions & 4 deletions docs/authorization/scopes_and_consents/scopes.rst
Original file line number Diff line number Diff line change
Expand Up @@ -282,10 +282,6 @@ ScopeBuilder Constants

.. listknownscopes:: globus_sdk.scopes.TimersScopes

.. note::

``TimersScopes`` is also available under the legacy name ``TimerScopes``.


.. py:data:: globus_sdk.scopes.data.TransferScopes

Expand Down
2 changes: 1 addition & 1 deletion docs/services/index.rst
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,6 @@ very simply:
flows
groups
search
timer
timers
transfer
gcs
8 changes: 0 additions & 8 deletions docs/services/timer.rst → docs/services/timers.rst
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,6 @@ Globus Timers

.. currentmodule:: globus_sdk

.. note::

``TimersClient`` is also available under a legacy alias, ``TimerClient``.

.. autoclass:: TimersClient
:members:
:member-order: bysource
Expand Down Expand Up @@ -50,10 +46,6 @@ Client Errors
When an error occurs on calls to the Timers service, a :class:`TimersClient`
will raise a ``TimersAPIError``.

.. note::

``TimersAPIError`` is also available under a legacy alias, ``TimerAPIError``.

.. autoclass:: TimersAPIError
:members:
:show-inheritance:
9 changes: 9 additions & 0 deletions docs/upgrading.rst
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,15 @@ Then, code can dispatch with
From 3.x to 4.0
---------------

Deprecated Timers Aliases Removed
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

During the version 3 lifecycle, the ``TimersClient`` and ``TimersAPIError``
classes were renamed. Their original names, ``TimerClient`` and
``TimerAPIError`` were retained as compatibility aliases.

These have been removed. Use ``TimersClient`` and ``TimersAPIError``.

Deprecated Experimental Aliases Removed
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Expand Down
3 changes: 0 additions & 3 deletions scripts/ensure_exports_are_documented.py
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,6 @@
DEPRECATED_NAMES = {
"ComputeFunctionDocument",
"ComputeFunctionMetadata",
"TimerAPIError",
"TimerClient",
"TimerScopes",
}


Expand Down
3 changes: 0 additions & 3 deletions src/globus_sdk/__init__.pyi
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,6 @@ from .services.search import (
SearchQueryV1,
SearchScrollQuery,
)
from .services.timer import TimerAPIError, TimerClient
from .services.timers import (
OnceTimerSchedule,
RecurringTimerSchedule,
Expand Down Expand Up @@ -233,8 +232,6 @@ __all__ = (
"SearchQuery",
"SearchQueryV1",
"SearchScrollQuery",
"TimerAPIError",
"TimerClient",
"OnceTimerSchedule",
"RecurringTimerSchedule",
"TimerJob",
Expand Down
20 changes: 0 additions & 20 deletions src/globus_sdk/scopes/__init__.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
import sys
import typing as t

from ._normalize import scopes_to_scope_list, scopes_to_str
from .builder import ScopeBuilder
from .data import (
Expand Down Expand Up @@ -33,25 +30,8 @@
"GroupsScopes",
"NexusScopes",
"SearchScopes",
"TimerScopes",
"TimersScopes",
"TransferScopes",
"scopes_to_str",
"scopes_to_scope_list",
)


if t.TYPE_CHECKING:
TimerScopes = TimersScopes
else:

def __getattr__(name: str) -> t.Any:
from globus_sdk.exc import warn_deprecated

if name == "TimerScopes":
warn_deprecated(
"'TimerScopes' is a deprecated name. Use 'TimersScopes' instead."
)
setattr(sys.modules[__name__], name, TimersScopes)
return TimersScopes
raise AttributeError(f"module {__name__} has no attribute {name}")
41 changes: 0 additions & 41 deletions src/globus_sdk/services/timer.py

This file was deleted.

12 changes: 0 additions & 12 deletions tests/non-pytest/mypy-ignore-tests/timer_client_aliasing.py

This file was deleted.

60 changes: 0 additions & 60 deletions tests/unit/services/timers/test_legacy_names.py

This file was deleted.