Add an entry to the upgrading doc for MutableScope #1200
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a small/minimal entry so that we're guaranteed to have something to build upon. It intentionally does not go into detail on how to use `Scope` because these interfaces are being redesigned.
sirosen
requested review from
MaxTueckeGlobus,
aaschaer,
ada-globus,
derek-globus,
kurtmckee and
m1yag1
as code owners
kurtmckee
approved these changes
May 29, 2025
Member
kurtmckee
left a comment
kurtmckee
left a comment
There was a problem hiding this comment.
Is it possible to use :class:`Scope` to create a reference link? That may be a helpful addition.
I'm marking this as approved, but this, and an inline suggestion, are my feedback.
Fix some phrasing and link to classes. Co-authored-by: Kurt McKee <39996+kurtmckee@users.noreply.github.com>
Member
Author
|
I didn't get nice behavior from |
kurtmckee
approved these changes
May 29, 2025
Member
|
Should this merge to |
Member
Author
|
I don't really want to backport doc changes from A separate 3.x -specific bit of doc in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I intentionally omitted any doc update when removing
MutableScope, but have reconsidered.I think a minimal stub is still worth adding, and we can enhance it later.
This is a small/minimal entry so that we're guaranteed to have something to build upon.
It intentionally does not go into detail on how to use
Scopebecause these interfaces are being redesigned.📚 Documentation preview 📚: https://globus-sdk-python--1200.org.readthedocs.build/en/1200/