Remove the 'MutableScope' type #1198
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sirosen
requested review from
MaxTueckeGlobus,
aaschaer,
ada-globus,
derek-globus,
kurtmckee and
m1yag1
as code owners
This is deprecated in 3.x in favor of the 'Scope' type. As part of our 4.0 release, we will be removing the 'MutableScope' type. This removes the type itself, and then handles all of the cascading fixes this necessitates. No update to the upgrading doc is included yet, as we have additional plans to make changes to the scope interfaces.
sirosen
force-pushed
the
remove-mutable-scope
branch
from
eb17420 to
f740fe5
Compare
`Scope.scopes2str` does not exist -- this test was created by a `MutableScope` replacement but the `Scope` and `MutableScope` interfaces differ here. Remove the bad test case.
kurtmckee
approved these changes
May 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is deprecated in 3.x in favor of the 'Scope' type. As part of our
4.0 release, we will be removing the 'MutableScope' type.
This removes the type itself, and then handles all of the cascading
fixes this necessitates.
No update to the upgrading doc is included yet, as we have additional
plans to make changes to the scope interfaces.
📚 Documentation preview 📚: https://globus-sdk-python--1198.org.readthedocs.build/en/1198/