Make 'GlobusAPIError.code' default to 'None' #1190
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the source tree, the default is changed from `"Error"` to `None`. In the tests, various direct tests are updated, as are those which inspect the arguments passed to `super().__init__` and which feed into the repr for an API error. There are no paths in the source tree of the SDK itself which depend upon the old default of `"Error"`.
sirosen
requested review from
MaxTueckeGlobus,
aaschaer,
ada-globus,
derek-globus,
kurtmckee and
m1yag1
as code owners
kurtmckee
approved these changes
May 14, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[sc-26347]
In the source tree, the default is changed from
"Error"toNone.In the tests, various direct tests are updated, as are those which inspect the arguments passed to
super().__init__and which feed into the repr for an API error.There are no paths in the source tree of the SDK itself which depend upon the old default of
"Error".📚 Documentation preview 📚: https://globus-sdk-python--1190.org.readthedocs.build/en/1190/