Remove the "default requested scopes" #1186
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sirosen
requested review from
MaxTueckeGlobus,
aaschaer,
ada-globus,
derek-globus,
kurtmckee and
m1yag1
as code owners
These were the default for login flows and client credentials. When GlobusApp-driven logins are used, these defaults are not used. They were only applied for direct use of the login flow and token request mechanisms for login clients. One log line has been changed to produce slightly more useful debug-level logs. Also, introduce the first v3.x -> v4 upgrading section to the upgrading doc.
sirosen
force-pushed
the
remove-default-scopes
branch
from
7cd086b to
c300c94
Compare
Fix typing errors where `... | None` was passed for `requested_scopes`. Additionally, to handle cases in GlobusApp, raise usage errors if an app is ever doing a login without provided scopes in the authorization parameters. These conditions aren't unreachable based on the types which are used, but a user who configures things to reach these conditions is engaged in explicitly unsupported usage (e.g., trying to give explicit parameters to a client app which don't include scopes).
kurtmckee
reviewed
May 12, 2025
kurtmckee
approved these changes
May 12, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[sc-20185]
These were the default for login flows and client credentials. When GlobusApp-driven logins are used, these defaults are not used. They were only applied for direct use of the login flow and token request mechanisms for login clients.
One log line has been changed to produce slightly more useful debug-level logs.
Also, introduce the first v3.x -> v4 upgrading section to the upgrading doc.
📚 Documentation preview 📚: https://globus-sdk-python--1186.org.readthedocs.build/en/1186/