-
Notifications
You must be signed in to change notification settings - Fork 44
Remove base_path from all client classes #1185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove base_path from all client classes #1185
Conversation
sirosen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a couple of minor adjustments I'd like to make. One is definitely debatable (trailing slash). Overall, excited for getting this into v4!
|
The updated changes look good, but we need a changelog for this. Removed
~~~~~~~
- SDK clients no longer define a ``base_path`` attribute which they prefix to paths.
Make sure to use the full path when using client methods. (:pr:`1185`) |
Do we want to have some special naming convention for the v4 changelogs / update the workflow to check for new changelogs against the correct branch? |
|
I don't think we need any special naming for the changelog files or contents -- by being in the We should fix the changelog checking workflow, but I don't think it's a blocker right now. |
changelog.d/20250512_144528_max.tuecke_sc_26346_remove_base_path_from_clients.rst
Outdated
Show resolved
Hide resolved
kurtmckee
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I left feedback regarding the changelog fragment phrasing but approve of the changes already here.
As noted in a comment, I don't think that more work needs to be done in this particular PR, which is well-targeted and sized.
sirosen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy with this, but recommend resolving the changelog thread before merging -- I think we could also merge and fix the changelog in follow-up, potentially along with an upgrading doc section.
sc-26346
Changes
base_pathdeclarations have been removed from all client classes.Reviewer notes:
base_pathsince many tests were not including thebase_pathfor a service when creating aRegisteredResponse. Rather than update each individual test, I chose to updateRegisteredResponseto always add a particular servicesbase_pathto the path if it was not included.BaseClient,BaseClient.base_urlwill always have a trailing slash added if needed.📚 Documentation preview 📚: https://globus-sdk-python--1185.org.readthedocs.build/en/1185/