Improve 'bookmark list' failure test case #1226
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Migrate off of the old fixture file and onto new `globus_sdk.testing` based response mocks, which are included in the test functions themselves. As a direct consequence of this refactor, it is obvious that there are two different failure modes encoded into the fixture (one soft and one hard), but only one of the two is tested. Split the test into the two relevant cases. One of the new cases overlaps with the success test case tested in the same file. This is noted in a TODO comment to remove the test redundancy.
sirosen
requested review from
MaxTueckeGlobus,
aaschaer,
ada-globus,
derek-globus,
kurtmckee and
m1yag1
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate off of the old fixture file and onto new
globus_sdk.testingbased response mocks, which are included in the test functions
themselves. As a direct consequence of this refactor, it is obvious that
there are two different failure modes encoded into the fixture (one soft
and one hard), but only one of the two is tested. Split the test into the
two relevant cases.
One of the new cases overlaps with the success test case tested in the
same file. This is noted in a TODO comment to remove the test redundancy.