Refresh the tox environment list and factorization #1224
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
'tox l' no longer shows environments with no description.
These tests are quick and give us more complete coverage of repo invariants when `tox p` is run.
An unintended environment name, like `py3.9-mypy` won't run "something": instead it will explicitly fail. Using more structured base envs gives the tox.ini file itself a clearer layout. Allowing this inheritance simplifies the conditional factors in the testenvs.
This is no longer used for any tox environments. Remove it.
sirosen
requested review from
MaxTueckeGlobus,
aaschaer,
ada-globus,
derek-globus,
kurtmckee and
m1yag1
as code owners
kurtmckee
reviewed
Dec 29, 2025
Split 'twine-check' vs 'check-sdist' tox envs so that each check is run separately (rather than bundled), using environment inheritance to minimize repetition. Co-authored-by: Kurt McKee <39996+kurtmckee@users.noreply.github.com>
sirosen
force-pushed
the
tox-env-refresh
branch
from
70c895e to
d693cf0
Compare
kurtmckee
approved these changes
Dec 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The overall goal here is to have clearer and more maintainable tox config, without accidentally inheriting things from the default testenv.
Base envs are also a good way to share config explicitly across envs.
Incidentally, add py3.14 to our tox envs (but not added yet in CI, to reduce scope creep).