Improve test coverage by adding tests and removing dead code, bump fail-under to 92% #1222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an unused module which is never even tested.
This helper is no longer used and not covered in tests.
'display_name_or_cname' is only used in one place and can be made into a single line, inlined at the usage site.
This option was previously untested, but allows commands to rewrite the exit status which will be used by top-level exception handlers, based on the HTTP status of the underlying (failing) response.
These unit tests cover previously uncovered code.
Explore the features of `globus version`, including the diagnostic output provided with `-v` and `-vv`. In the course of these tests, deprecation warnings were uncovered related to use of `click.__version__`. Therefore, upgrade the command to use `importlib.metadata` instead.
sirosen
requested review from
MaxTueckeGlobus,
derek-globus,
kurtmckee and
m1yag1
as code owners
kurtmckee
approved these changes
Dec 24, 2025
| patch = ["subprocess"] | ||
| source = ["globus_cli"] | ||
| omit = [ | ||
| "globus_cli_flake8.py", |
Member
There was a problem hiding this comment.
I have a feeling this shouldn't be in the src/ tree to begin with, but this is currently a helpful omission!
Member
Author
There was a problem hiding this comment.
Yeah, I can understand that. In SDK we put the sphinx stuff (similar) into src/globus_sdk/_internal/. We need various things to be importable in different contexts (e.g., tests) and I've not worked out a uniform pattern for this yet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Examining coverage reports for the CLI shows that there are several large untested blobs.
A case-by-case evaluation reveals that several of these can be improved dramatically with minimal effort.
--map-http-statusIdentityTypeglobus versionOnly this last item (
globus version) required any meaningful change in the src tree, as it uncovered a deprecation warning whenglobus version -vis run.The fix is simply an update to use
importlib.metadatato retrieve package version info.