Skip to content

Conversation

@sirosen
Copy link
Member

@sirosen sirosen commented Dec 22, 2025

This reports coverage info in CI output, and importantly checks the
fail-under value.

This reports coverage info in CI output, and importantly checks the
fail-under value.
@sirosen sirosen added the no-news-is-good-news This change does not require a news file label Dec 22, 2025
@sirosen sirosen added the no-news-is-good-news This change does not require a news file label Dec 22, 2025
@sirosen
Copy link
Member Author

sirosen commented Dec 22, 2025

I am surprised to learn two things!

  1. We aren't collecting coverage in CI Nevermind! Just a missing coverage combine step!
  2. We are passing --fail-under=0 in cov-report!

The separate testenv
- incorporates `coverage combine` invocation automatically
- does not pass `--fail-under`, getting the value from config instead
@sirosen sirosen merged commit 83e8979 into globus:main Dec 22, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-news-is-good-news This change does not require a news file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants