Remove the 'testing' module #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a *large* surface area exposed via a very small number of low-utility test helpers. The contracts here cannot be maintained as the main source itself changes, and therefore each change to the source requires an attendant change to the testing helpers and documentation of the change in both locations. Move the only "surviving" test in `test_mocks` to a new `test_meta` test module.
sirosen
requested review from
ada-globus,
derek-globus,
jakeglobus,
kurtmckee and
MaxTueckeGlobus
as code owners
ada-globus
approved these changes
Oct 11, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a large surface area exposed via a very small number of
low-utility test helpers. The contracts here cannot be maintained as
the main source itself changes, and therefore each change to the
source requires an attendant change to the testing helpers and
documentation of the change in both locations.
Move the only "surviving" test in
test_mocksto a newtest_metatest module.