Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

numberParser incorrect when no integer is included #443

Closed
Mottie opened this issue May 2, 2015 · 1 comment · Fixed by #656
Closed

numberParser incorrect when no integer is included #443

Mottie opened this issue May 2, 2015 · 1 comment · Fixed by #656
Labels
bug

Comments

@Mottie
Copy link
Contributor

Mottie commented May 2, 2015

I set up this demo using only a partial set of data, so maybe I'm doing it wrong...

Globalize.numberParser()('.44');
// result = 44 (no decimal point)
Globalize.numberParser()('0.44');
// result = .44
@rxaviers
Copy link
Member

rxaviers commented May 3, 2015

Thanks for pointing it out. .numberParser()('.44') should definitely not return 44.

@rxaviers rxaviers mentioned this issue May 3, 2015
Closed
6 tasks
@rxaviers rxaviers added the bug label Jun 3, 2015
@kborchers kborchers mentioned this issue Jun 18, 2015
Closed
This was referenced Oct 2, 2015
Closed
Closed
rxaviers pushed a commit that referenced this issue Jan 17, 2016
@Mottie @rxaviers
Number Parse: Add padding zero to leading decimal
d0002f8 
Fixes #443
Ref #454
Ref #517
rxaviers added a commit that referenced this issue Nov 28, 2016
@rxaviers
Number Parse: Refactor for improved algorithm
be9bb9f 
- Correctly handles prefix and suffix literals; #353;
- Loose Matching: This implementation is now much closer to UTS#35 7.1.2 Loose
  Matching http://unicode.org/reports/tr35/#Loose_Matching and fixes all
  reported cases that related to it, including #288;
- Regression: Drop scientific notation parsing support, which wasn't documented
  anyway and shall be implemented by #533.

Ref #292
Fixes #353

Fixes #46
Fixes #288
Fixes #443
Fixes #457
Fixes #492
Fixes #587
Fixes #644
@rxaviers rxaviers mentioned this issue Nov 28, 2016
Merged
rxaviers added a commit that referenced this issue Nov 28, 2016
@rxaviers
Number Parser: Refactor for improved algorithm
4f6b05a 
- Correctly handles prefix and suffix literals; #353;
- Loose Matching: This implementation is now much closer to UTS#35 7.1.2 Loose
  Matching http://unicode.org/reports/tr35/#Loose_Matching and fixes all
  reported cases that are related to it, including #288;
- Regression: Drop scientific notation parsing support, which wasn't documented
  anyway and shall be implemented by #533.

Ref #292
Fixes #353

Fixes #46
Fixes #288
Fixes #443
Fixes #457
Fixes #492
Fixes #587
Fixes #644
rxaviers added a commit that referenced this issue Dec 13, 2016
@rxaviers
Number Parser: Refactor for improved algorithm
bba6a5e 
- Correctly handles prefix and suffix literals; #353;
- Loose Matching: This implementation is now much closer to UTS#35 7.1.2 Loose
  Matching http://unicode.org/reports/tr35/#Loose_Matching and fixes all
  reported cases that are related to it, including #288;
- Regression: Drop scientific notation parsing support, which wasn't documented
  anyway and shall be implemented by #533.

Ref #292
Fixes #353

Fixes #46
Fixes #288
Fixes #443
Fixes #457
Fixes #492
Fixes #587
Fixes #644
rxaviers added a commit that referenced this issue Dec 13, 2016
@rxaviers
Number Parser: Refactor for improved algorithm
637cbd3 
- Correctly handles prefix and suffix literals; #353;
- Loose Matching: This implementation is now much closer to UTS#35 7.1.2 Loose
  Matching http://unicode.org/reports/tr35/#Loose_Matching and fixes all
  reported cases that are related to it, including #288;
- Regression: Drop scientific notation parsing support, which wasn't documented
  anyway and shall be implemented by #533.

Ref #292
Fixes #353

Fixes #46
Fixes #288
Fixes #443
Fixes #457
Fixes #492
Fixes #587
Fixes #644
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Number Parser: Refactor for improved algorithm globalizejs/globalize
2 participants
@Mottie @rxaviers