Skip to content
This repository was archived by the owner on Jan 15, 2022. It is now read-only.

Configurable paginator button labels (#229) #261

Merged
merged 1 commit into from
Mar 24, 2016

Conversation

nscarcella
Copy link

Hi,

I am working in a project in Spanish and the paginator buttons looked a bit out of place, so I added two props previousPageLabel and nextPageLabel in order to be able to pass a localized text to my table.

I didn't change the default 'Previous' and 'Next' texts as #229 suggested to avoid any backward compatibility issues (though I do think '<<' and '>>' are a nice, more international, alternative).

I manually only changed the following files:

  • paginator.jsx
  • table.jsx
  • reactable_test.jsx

All other changes in the commit where caused by the build, which I guess was a bit out of sync because I see changes there that could not possible have any relation with my changes : P

Please let me know what you think and if there is anything else I can do to help.

@glittershark
Copy link
Owner

Nice! thanks! Appreciate the concern for backwards compatibility.

@nscarcella
Copy link
Author

Awesome! Thanks for answering so quickly!

I left another PR just in case that adds a line about this change to the README.(#262)

Do you have any idea when can I expect a version increment containing this change in npm?

@glittershark
Copy link
Owner

as soon as the README PR is merged I'll bump a patch version

glittershark added a commit that referenced this pull request Mar 24, 2016
+ Add a warning when unexpected children are passed to a `<Table>` (#256)
+ Make pagination labels configurable (#261)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants