This repository was archived by the owner on Jan 15, 2022. It is now read-only.
Added default sort descending flag and documentation in readme #230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Add some tests and this is good to go 😄 |
|
💯 |
glittershark
added a commit
that referenced
this pull request
Jan 15, 2016
+ Add support for onFilter event prop (#235) (@educastellano) + Add defaultSortDescending prop to table (#230) (@JohnathanBruce)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically this is a feature request for allowing the user to set the default sort to descending on a JSX component flag.
Originally I had it as a string but then I realized it was kind of pointless seeing that it's 1 or -1 and by default it's ascending.