This repository was archived by the owner on Jan 22, 2026. It is now read-only.
Resisted prickly sand: add Optimistic Inputs to shared components #97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
./.glitch-assets:271885/382
./.glitch-assets:271885/772
./.glitch-assets:9/1545
./lib/optimistic-inputs.js:708175/632 ./lib/stories.js:708175/38
./lib/optimistic-inputs.js:97325/93:708175/1077 ./lib/hooks/use-optimistic-value.js:97325/69
GregWeil
approved these changes
Mar 20, 2020
Contributor
GregWeil
left a comment
GregWeil
left a comment
There was a problem hiding this comment.
Looks good, left a small comment on proptypes (since it wraps onBlur before passing it along)
| OptimisticInput.propTypes = { | ||
| value: PropTypes.string.isRequired, | ||
| onChange: PropTypes.func.isRequired, | ||
| Component: PropTypes.elementType.isRequired, |
Contributor
There was a problem hiding this comment.
This should include onBlur as an optional function
Contributor
|
🚀 PR was released in |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
src/components/fields/optimistic-text-input.jsfrom community<OptimisticInput Component={MarkdownInput} .. />to replace optimistic-markdown-input,<OptimisticInput Component={WrappingTextInput} .. />to replace optimistic-wrapping-input, etc.After this is released, we can remove the hooks related to optimistic values and the various components from the community site and replace them with these.