Skip to content
This repository was archived by the owner on Jan 22, 2026. It is now read-only.

Conversation

@clottman
Copy link
Contributor

@clottman clottman commented Mar 6, 2020

Updated testing-shared-components-locally-in-another-project instructions. Inspired by slack conversation

@clottman clottman requested a review from keithk March 6, 2020 19:08
Copy link
Contributor

@keithk keithk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I wonder if (in the future) we could put all of the link specific stuff (adding it, removing it when you're done) into a script file to make this easier.

@clottman
Copy link
Contributor Author

clottman commented Mar 6, 2020

I think the script file approach would be challenging because it would have to make assumptions about the file structure - on my machine Glitch-Community and shared-components are in the same parent folder, so you can cd ../shared-components from /Glitch-Community and be in the right place, but that might not be the case for everyone for whatever reason.

@clottman clottman merged commit 18646b5 into master Mar 16, 2020
@keithk
Copy link
Contributor

keithk commented Nov 10, 2020

🚀 PR was released in v0.19.0 🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants